Skip to content

feat(scripts): add roadmap issue-drift check (#8390) - #8413

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jsdevninja:feat/roadmap-issue-drift-check
Jul 24, 2026
Merged

feat(scripts): add roadmap issue-drift check (#8390)#8413
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jsdevninja:feat/roadmap-issue-drift-check

Conversation

@jsdevninja

@jsdevninja jsdevninja commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Test plan

@jsdevninja
jsdevninja requested a review from JSONbored as a code owner July 24, 2026 12:16
@superagent-security

superagent-security Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.42%. Comparing base (712836f) to head (4e364c3).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8413   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         791      791           
  Lines       79259    79259           
  Branches    23948    23948           
=======================================
  Hits        73252    73252           
  Misses       4868     4868           
  Partials     1139     1139
Flag Coverage Δ
shard-1 57.75% <ø> (+4.41%) ⬆️
shard-2 47.71% <ø> (-4.74%) ⬇️
shard-3 56.55% <ø> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 24, 2026
@loopover-orb

loopover-orb Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-24 12:43:24 UTC

3 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
Adds a new standalone script + npm script that parses ROADMAP_ITEMS from roadmap.tsx via regex and flags active/upcoming items whose linked GitHub issue is closed as completed, mirroring the existing check-stuck-required-checks.ts pattern (injected GithubApi, pure logic separated from a guarded main()). The pure comparison and parser are well covered by 14 unit tests with no network calls, and the regex-based parser is validated against the real roadmap.tsx source in-repo. This is a manual/scheduled-only diagnostic tool deliberately not wired into test:ci, so its risk surface is low; the `any`-typed GithubApi and console-based CLI output are consistent with the sibling script's established conventions in this repo.

Nits — 5 non-blocking
  • The brace-matching regex in parseRoadmapItems (scripts/check-roadmap-issue-drift.ts:64) uses `[^{}]+` per object, which would silently break parsing if a roadmap item's description ever contains a nested `{}` — worth a comment noting that assumption since it's a hand-rolled parser rather than a real TS/AST parse.
  • console-based logging in main() (scripts/check-roadmap-issue-drift.ts:151-159) is fine for a manual CLI but mirrors debug-style output; consistent with check-stuck-required-checks.ts convention so not a real concern.
  • The `any`-typed GithubApi (scripts/check-roadmap-issue-drift.ts:32) is explicitly justified in a comment and matches the existing sibling script's convention, so this is a deliberate, documented choice rather than a slip.
  • Hardcoded `api.github.com` host (scripts/check-roadmap-issue-drift.ts:36) matches the same hardcoded host in check-stuck-required-checks.ts, so it's consistent with existing convention rather than a new pattern to flag.
  • Consider extracting the shared makeGithubApi implementation (identical between this file and check-stuck-required-checks.ts) into a small shared module to avoid drift between the two copies over time.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8390
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 215 registered-repo PR(s), 130 merged, 39 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jsdevninja; Gittensor profile; 215 PR(s), 39 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The PR adds scripts/check-roadmap-issue-drift.ts which parses ROADMAP_ITEMS, checks issue state/stateReason via the GitHub API, and fails loudly only for shipping-soon/planned items closed as COMPLETED (exploring items are excluded), plus a roadmap:drift-check npm script and a network-free unit test covering the comparison and parsing logic, matching the issue's requirements without touching CI or

Review context
  • Author: jsdevninja
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 215 PR(s), 39 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

loopover-orb[bot]
loopover-orb Bot approved these changes Jul 24, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 191db76 into JSONbored:main Jul 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loopover-orb loopover-orb[bot] loopover-orb[bot] approved these changes
@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@jsdevninja jsdevninja

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a drift check: /roadmap presents 7 issues as active/upcoming that are all actually closed as completed

1 participant

@jsdevninja